RFR (XS/T) 8245703: 32-bit build failures after JDK-8243392

David Holmes david.holmes at oracle.com
Mon May 25 07:56:12 UTC 2020


Hi Aleksey,

On 25/05/2020 4:54 pm, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8245703
> 
> Fix:
> 
> diff -r 438102b06fc0 src/hotspot/share/memory/metaspaceShared.cpp
> --- a/src/hotspot/share/memory/metaspaceShared.cpp      Mon May 25 11:29:56 2020 +0800
> +++ b/src/hotspot/share/memory/metaspaceShared.cpp      Mon May 25 08:51:16 2020 +0200
> @@ -259,5 +259,7 @@
>     assert(DumpSharedSpaces, "should be called for dump time only");
> 
> +#ifdef _LP64
>     check_SharedBaseAddress();
> +#endif

I'd prefer

LP64_ONLY(check_SharedBaseAddress();)

but either way looks good and trivial.

Thanks,
David
-----

>     const size_t reserve_alignment = MetaspaceShared::reserved_space_alignment();
> 
> Testing: x86_32 builds
> 


More information about the hotspot-runtime-dev mailing list