RFR: 8256485: Zero VM build broken after JDK-8254231 [v2]

Aleksey Shipilev shade at openjdk.java.net
Mon Nov 23 13:31:57 UTC 2020


On Mon, 23 Nov 2020 13:21:09 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> This function gets called during the build. If the case for linkToNative is not added it falls through to ShouldNotReachHere() in the default case.
>> 
>> Pointing it to method_handle_entry_invalid seemed like the best way to fix it, since the interpreter entry never gets used any ways. See method.cpp:
>> 
>>   if (iid == vmIntrinsics::_linkToNative) {
>>     m->set_interpreter_entry(m->adapter()->get_i2c_entry());
>>   }
>
> (Though, I suppose in general the entry never gets used because we don't have a CLinker implementation for Zero)

Then I suggest doing what `ZeroInterpreterGenerator::generate_abstract_entry` does and generate the entry that "calls" `ShouldNotCallThisEntry()`. Which means the build would succeed, but the attempt to actually call through `_linkToNative` would fail in a proper place.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1265


More information about the hotspot-runtime-dev mailing list