RFR: 8256675: Zero: purge biased locking support [v2]

Aleksey Shipilev shade at openjdk.java.net
Mon Nov 23 19:21:00 UTC 2020


On Mon, 23 Nov 2020 19:11:07 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Hi Aleksey,
>> 
>> Changes look good to me. 
>> There are 3 places left when unlocking the monitor where there is a has_bias_pattern() check. Maybe change them into an assert? (seems Github doesn't allow to add comments on collapsed lines).
>> 
>> Thanks,
>> Patricio
>
>> That another commit that removes all `has_bias_pattern()`-s looks fine to you, @pchilano?
> Yes, looks good. (Not sure why I thought you already pushed).
> My suggestion was actually to assert that at monitorexit the markword cannot be biased, but still good.

Thanks! I think we can believe that `!UseBiasedLocking` means no one else biases the object, or can bias it later.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1322


More information about the hotspot-runtime-dev mailing list