RFR: 8252324: Signal related code should be shared among POSIX platforms [v5]
Gerard Ziemski
gziemski at openjdk.java.net
Thu Oct 1 18:17:06 UTC 2020
On Wed, 30 Sep 2020 23:24:25 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Sorry for taking so long, but this is my 1st github pr and I did not liked the merge issues that David discovered and
>> tried to redo the merge, but I keep getting it wrong.
>> I just forced pushed update removing the BIG merge and I keep working on it, hopefully without introducing another huge
>> merge. If anyone has tips on how to apply local changes (i.e. rebase/stash?) without having to merge, please let me
>> know. Once I figure this out, I will re-implement the few, non-merge, issues that David discovered and this will be
>> ready for integration.
>
> @gerard-ziemski Please do not force-push any commits in an open PR as it breaks the commit history and the chain of
> review comments. I will not be able to see the merge issues actually fixed as a diff from the previous commit.
> merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your
> intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of
> this pull request to `Merge <project>:<branch>` where `<project>` is the name of another project in the [OpenJDK
> organization](https://github.com/openjdk) (for example `Merge jdk:master`).
Can anyone explain what this means and whether it's OK to go ahead with this pr, or should I close this one (since I
made quite a mess of it) and start a new one?
-------------
PR: https://git.openjdk.java.net/jdk/pull/157
More information about the hotspot-runtime-dev
mailing list