RFR: 8253794: TestAbortVMOnSafepointTimeout never timeouts [v2]

[Robbin Ehn]

On Mon, 5 Oct 2020 18:21:43 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update with input from reviews
>
> Pushing the small update in a minute.

> Robbin replied:
> 
> > David H. wrote:
> > > That all said, for the record, we really should have a handshake timeout mechanism the same as we have the safepoint
> > > timeout mechanism.
> > 
> > 
> > We have a timeout mechanism but default off HandshakeTimeout.
> > But it doesn't fire SIGILL to troubled thread as safepoint does.
> 
> What's the conclusion here? Are there going to be changes to the
> test to use the HandshakeTimeout option? Should the test have
> failed in a different way than it did?

In https://bugs.openjdk.java.net/browse/JDK-8198730 I'm have been looking into setting these (safepoint and handshake
timeout ) to default 1 second. There were some impediments which now seems to have been resolved. If any of these
operations takes longer you want to know it because A: you have a bug, or B: you have performance problems. So I don't
think the default value is what any user wants.

-------------

PR: https://git.openjdk.java.net/jdk/pull/465