RFR: 8253794: TestAbortVMOnSafepointTimeout never timeouts [v3]

Robbin Ehn rehn at openjdk.java.net
Mon Oct 5 18:34:04 UTC 2020


> The issue is that this test doesn't consider Handshake All operation.
> Depending if/when such operation is scheduled it can lockup the VM thread.
> And the safepoint that should timeout never happens.
> See issue for more information.
> 
> So I changed the test to "try timeout" the safepoint, but if there was no safepoint (blocked by a handshake all), we
> retry. We sleep unsafe much longer than the interval SafepointALot generates operations, which 'guarantees' we will
> timeout if there is no handshake all. (some extreme case of kernel scheduling causing a very long context switch could
> also make us not timeout)  Passes t1, t3, and repeat runs of the test.

Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since
the last revision:

 - Fixed include and comment
 - Merge branch 'master' into 8253794
 - Update with input from reviews
 - Fixed test

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/465/files
  - new: https://git.openjdk.java.net/jdk/pull/465/files/90fb3106..b63b6a09

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=465&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=465&range=01-02

  Stats: 8155 lines in 239 files changed: 3444 ins; 1770 del; 2941 mod
  Patch: https://git.openjdk.java.net/jdk/pull/465.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/465/head:pull/465

PR: https://git.openjdk.java.net/jdk/pull/465


More information about the hotspot-runtime-dev mailing list