RFR: 8254586: Replace fthrow() calls with simpler method calls in classFileParser.cpp [v2]

Harold Seigel hseigel at openjdk.java.net
Tue Oct 13 17:17:20 UTC 2020


On Mon, 12 Oct 2020 22:19:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8254586: Replace fthrow() calls with simpler method calls in classFileParser.cpp
>
> Looks good to me. I agree with David's comment to just pass THREAD and return;  Saves an implicit if statement in these
> places.

Thanks for looking at this change!  Please review the updated change that replaces CHECK* arguments with THREAD,
followed by 'return' statements.  This change was made for calls to the new methods and existing calls to
classfile_parse_error().

-------------

PR: https://git.openjdk.java.net/jdk/pull/618


More information about the hotspot-runtime-dev mailing list