RFR: 8254586: Replace fthrow() calls with simpler method calls in classFileParser.cpp [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Tue Oct 13 17:41:18 UTC 2020
On Tue, 13 Oct 2020 17:14:10 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
>> Looks good to me. I agree with David's comment to just pass THREAD and return; Saves an implicit if statement in these
>> places.
>
> Thanks for looking at this change! Please review the updated change that replaces CHECK* arguments with THREAD,
> followed by 'return' statements. This change was made for calls to the new methods and existing calls to
> classfile_parse_error().
This looks like a good improvement. It might make the size of the generated code in cfp smaller. Thanks!
-------------
PR: https://git.openjdk.java.net/jdk/pull/618
More information about the hotspot-runtime-dev
mailing list