RFR: 8255005: Fix indentation levels in classFileParser.cpp
Lois Foltan
lfoltan at openjdk.java.net
Thu Oct 29 16:08:43 UTC 2020
On Thu, 29 Oct 2020 13:02:04 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
> Please review this very small change to fix indentation in classFileParser.cpp and move the check for the PermittedSubclasses attribute inside of the "if (major_version >= 16)" block.
>
> Fix was tested with tiers 1 and 2 on Linux, Mac OSX, and Windows, and tiers 3-5 on Linux x64.
>
> Thanks, Harold
One minor nit for you to consider. Overall looks good!
src/hotspot/share/classfile/classFileParser.cpp line 3925:
> 3923: record_attribute_length = attribute_length;
> 3924: }
> 3925: cfs->skip_u1(attribute_length, CHECK);
Minor nit, since records, permitted subclasses and an unknown attribute type all do a "cfs->skip_u1(attribute_length, CHECK);" as the last action, you could pull that out to the end of the else if (_major_version >= JAVA_16_VERSION) statement.
-------------
Marked as reviewed by lfoltan (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/931
More information about the hotspot-runtime-dev
mailing list