RFR: 8255005: Fix indentation levels in classFileParser.cpp [v2]
Harold Seigel
hseigel at openjdk.java.net
Thu Oct 29 20:28:58 UTC 2020
On Thu, 29 Oct 2020 16:05:37 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:
>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8255005: Fix indentation levels in classFileParser.cpp
>
> src/hotspot/share/classfile/classFileParser.cpp line 3925:
>
>> 3923: record_attribute_length = attribute_length;
>> 3924: }
>> 3925: cfs->skip_u1(attribute_length, CHECK);
>
> Minor nit, since records, permitted subclasses and an unknown attribute type all do a "cfs->skip_u1(attribute_length, CHECK);" as the last action, you could pull that out to the end of the else if (_major_version >= JAVA_16_VERSION) statement.
Thanks for looking at this. Please see latest commit that contains the changes you suggested.
-------------
PR: https://git.openjdk.java.net/jdk/pull/931
More information about the hotspot-runtime-dev
mailing list