RFR: 8247281: migrate ObjectMonitor::_object to OopStorage [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Fri Sep 11 21:45:12 UTC 2020


On Fri, 11 Sep 2020 21:33:33 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   coleenp CR - changes to resolve Coleen's comments.
>
> src/hotspot/share/runtime/thread.cpp line 4593:
> 
>> 4591:   // are used in om_flush().
>> 4592:   BarrierSet::barrier_set()->on_thread_detach(p);
>> 4593:
> 
> One last question, that doesn't require a comment why it's here, but why was this moved?

We had to move that code to make om_flush() happy.
om_flush() accesses the (weak) oops in the monitor list
after the thread is off the threads list so the barrier change
had to move. It will move back in part3.

-------------

PR: https://git.openjdk.java.net/jdk/pull/135


More information about the hotspot-runtime-dev mailing list