RFR: 8247281: migrate ObjectMonitor::_object to OopStorage [v2]

David Holmes dholmes at openjdk.java.net
Mon Sep 14 02:04:25 UTC 2020


On Fri, 11 Sep 2020 21:35:41 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> src/hotspot/share/runtime/thread.cpp line 4593:
>> 
>>> 4591:   // are used in om_flush().
>>> 4592:   BarrierSet::barrier_set()->on_thread_detach(p);
>>> 4593:
>> 
>> One last question, that doesn't require a comment why it's here, but why was this moved?
>
> We had to move that code to make om_flush() happy.
> om_flush() accesses the (weak) oops in the monitor list
> after the thread is off the threads list so the barrier change
> had to move. It will move back in part3.

Just to be clear the thread is still on the threads_list at this point.

-------------

PR: https://git.openjdk.java.net/jdk/pull/135


More information about the hotspot-runtime-dev mailing list