RFR: 8253089: Windows (MSVC 2017) build fails after JDK-8243208

[Kim Barrett]

> On Sep 16, 2020, at 7:24 AM, Aleksey Shipilev <shade at openjdk.java.net> wrote:
> 
> On Mon, 14 Sep 2020 22:25:06 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> 
>>> It seems that MSVC 2017 is getting confused about the differences in `unsigned int` and `u2`. After a few attempts at
>>> fixing this, I think we need to use `u2` consistently for hash code computations. `u2` is the final storage type for
>>> the hash code in `JVMFlagLookup::_hashes`.
>> 
>> Marked as reviewed by iklam (Reviewer).
> 
> I don't mind reverting this change, but it would break MSVC 2017 again, until we push the pragmas. Unfortunately, I
> lost the capability to build with MSVC 2017, so maybe we should ask SAP folks (who IIRC still have their pipelines with
> MSVC 2017) to verify this still works.

I’m guessing this was intended to be in response to my followup comment.

I agree that we can’t revert that until we have something in place to deal with the VS2017 problem.  It was the SAP
folks who reported the new failure to me, so I’m assuming they will be looking at whatever is done for that problem.

> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/150