RFR: 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API [v2]

[Ioi Lam]

On Tue, 27 Apr 2021 21:30:26 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> We currently have array_klass() and array_klass_or_null(), where the former can throw exceptions and the latter can not. But they both delegate to:
>> 
>> array_klass_impl(bool or_null, TRAPS)
>> 
>> which combines both the exception-throwing and non-exception-throwing code into one method declared with TRAPS. To make progress with the change of TRAPS to JavaThread (JDK-8252685) we need to separate these code paths into distinct methods.
>> 
>> Testing: tiers 1-3 (in progress)
>> 
>> Thanks,
>> David
>
> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge
>  - Feedback from Ioi and Coleen: make the base API pure virtual and override those methods
>    directly, getting rid of the impl versions,
>  - 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API

LGTM. Just a small nit about comments.

src/hotspot/share/oops/instanceKlass.cpp line 1457:

> 1455:     return NULL;
> 1456:   }
> 1457:   // _this will always be set at this point

I have a hard time understanding the meaning of the above comment. Maybe it should be removed? (Same foe line 1447).

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3711