RFR: 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API [v2]

[David Holmes]

On Tue, 27 Apr 2021 21:37:17 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge
>>  - Feedback from Ioi and Coleen: make the base API pure virtual and override those methods
>>    directly, getting rid of the impl versions,
>>  - 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API
>
> src/hotspot/share/oops/instanceKlass.cpp line 1457:
> 
>> 1455:     return NULL;
>> 1456:   }
>> 1457:   // _this will always be set at this point
> 
> I have a hard time understanding the meaning of the above comment. Maybe it should be removed? (Same foe line 1447).

Until you quoted it I hadn't noticed the underscore on _this. I read it as "this [array_klasses()] will always be set [non-NULL] at this point".

I can restructure this as an if-else to make it crystal clear, and avoid the re-read of array_klasses().

-------------

PR: https://git.openjdk.java.net/jdk/pull/3711