RFR: 8272345: macos doesn't check `os::set_boot_path()` result [v2]

Igor Ignatyev iignatyev at openjdk.java.net
Thu Aug 12 03:50:25 UTC 2021


On Thu, 12 Aug 2021 03:38:51 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this small fix?
>> 
>> from JBS:
>>> we don't check `os::set_boot_path()` return value on macos, which leads to a crash/assert down the road in case we weren't able to set BCP. on all other OSes, we terminate JVM w/ "Failed setting boot class path." error message.
>> 
>> testing:
>> - [x] tier1
>> - [x] `runtime/cds/appcds/MoveJDKTest.java`
>> 
>> 
>> Thanks,
>> -- Igor
>
> Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   enable the test on all platforms but windows

Thanks, David.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5094


More information about the hotspot-runtime-dev mailing list