RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34

David Holmes dholmes at openjdk.java.net
Sat Aug 21 11:15:26 UTC 2021


On Fri, 20 Aug 2021 13:27:57 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Please review this simple test fix to address an issue that will prevent this test source from building on more recent Linux distributions with Glibc 2.34. When building under _GNU_SOURCE the value of SIGSTKSZ is no longer a constant and so cannot be used in an array declaration. The simple fix is to malloc the array instead.
>> 
>> Testing: local & mach5 tiers 1-3
>> 
>> Thanks,
>> David
>
> Looks fine. This is technically a memory leak, but we don't care much for the test code.

Thanks for the review @shipilev . I thought about freeing again but it seemed pointless when the test is going to exit anyway.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5200


More information about the hotspot-runtime-dev mailing list