RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34

Thomas Stuefe stuefe at openjdk.java.net
Sat Aug 21 13:37:26 UTC 2021


On Fri, 20 Aug 2021 12:39:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review this simple test fix to address an issue that will prevent this test source from building on more recent Linux distributions with Glibc 2.34. When building under _GNU_SOURCE the value of SIGSTKSZ is no longer a constant and so cannot be used in an array declaration. The simple fix is to malloc the array instead.
> 
> Testing: local & mach5 tiers 1-3
> 
> Thanks,
> David

Looks good. Leaking is fine here I think. I was confused about not having to cast till I remembered this is C.

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5200


More information about the hotspot-runtime-dev mailing list