RFR: 8278131: runtime/cds/appcds/dynamicArchive/* tests failing in loom repo
David Holmes
dholmes at openjdk.java.net
Wed Dec 15 22:37:05 UTC 2021
On Wed, 15 Dec 2021 17:35:24 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
> The appcds/dynamicArchive/RegularHiddenClass.java test makes use of the InstantitateHiddenClass and attempts
to dump a hidden class into the dynamic archive.
Ah I see - that makes more sense. May I suggest that a comment is added in InstantiateHiddenClass.java to indicate that it is also used by RegularHiddenClass which will pass the keep-alive option. Otherwise it looks very odd to expect a parameter that is seemingly not passed and for which there is no obvious reason for passing. Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6843
More information about the hotspot-runtime-dev
mailing list