RFR: 8278131: runtime/cds/appcds/dynamicArchive/* tests failing in loom repo

[Calvin Cheung]

On Wed, 15 Dec 2021 22:33:38 GMT, David Holmes <dholmes at openjdk.org> wrote:

> > The appcds/dynamicArchive/RegularHiddenClass.java test makes use of the InstantitateHiddenClass and attempts
> > to dump a hidden class into the dynamic archive.
> 
> Ah I see - that makes more sense. May I suggest that a comment is added in InstantiateHiddenClass.java to indicate that it is also used by RegularHiddenClass which will pass the keep-alive option. Otherwise it looks very odd to expect a parameter that is seemingly not passed and for which there is no obvious reason for passing. Thanks.

I've added the following comment:

    public static void main(String[] args) throws Throwable {
        // This class is also used by the appcds/dynamicArchive/RegularHiddenClass.java
        // test which will pass the "keep-alive" argument during dynamic CDS dump
        // for preventing from being GC'ed prior to the dumping operation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6843