RFR: 8278131: runtime/cds/appcds/dynamicArchive/* tests failing in loom repo [v2]

[David Holmes]

On Wed, 15 Dec 2021 18:22:33 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> A few dynamic archive CDS tests are failing in the loom repo due to more aggressive GC of code cache
>> which leads to unloading of some classes before being written into a dynamic CDS archive.
>> 
>> This change is to make the affected tests more reliable by ensuring the test classes are not unloaded
>> during dynamic CDS dump time.
>> 
>> Testing: Oracle CI tiers 1,2,4.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use the STRONG ClassOption to create a hidden class if the keepAlive is set

I find the overall handling of the extra keep-alive parameter somewhat awkward. It is far from clear which tests will be invoked with what set of parameters, and whether "keep-alive" is always passed, or only sometimes. If none of these tests actually rely on performing class unloading, then it would be simpler if they all unconditionally keep the classes alive.

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/6843