RFR: 8278131: runtime/cds/appcds/dynamicArchive/* tests failing in loom repo [v2]

Calvin Cheung ccheung at openjdk.java.net
Wed Dec 15 23:35:59 UTC 2021


On Wed, 15 Dec 2021 22:40:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I find the overall handling of the extra keep-alive parameter somewhat awkward. It is far from clear which tests will be invoked with what set of parameters, and whether "keep-alive" is always passed, or only sometimes. If none of these tests actually rely on performing class unloading, then it would be simpler if they all unconditionally keep the classes alive.
> 
> David

The "keep-alive" is needed only for dynamic CDS dumping; it is not required during runtime or static dumping. So I think
it is better to keep the "keep-alive" parameter so that other tests won't be impacted.
I've added some comments to the help classes.

thanks,
Calvin

-------------

PR: https://git.openjdk.java.net/jdk/pull/6843


More information about the hotspot-runtime-dev mailing list