RFR: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog() [v2]

Calvin Cheung ccheung at openjdk.java.net
Mon Feb 1 17:03:14 UTC 2021


> Please review this CDS tests cleanup for reducing the usage of `CDSTestUtils.executeAndLog()` by making use of `CDSTestUtils.run()`, `CDSTestUtils.createArchiveAndCheck()`, etc.
> 
> Testing: tiers 1 - 4.

Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:

  1. revert the changes in SharedStrings.java.
  2. replace most of the createArchive() calls with createArchiveAndCheck().
  3. factor out dumping a class list into the CDSTestUtils.dumpClassList() method.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2297/files
  - new: https://git.openjdk.java.net/jdk/pull/2297/files/e85a1081..500ba17f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2297&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2297&range=00-01

  Stats: 203 lines in 26 files changed: 16 ins; 109 del; 78 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2297.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2297/head:pull/2297

PR: https://git.openjdk.java.net/jdk/pull/2297


More information about the hotspot-runtime-dev mailing list