RFR: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog() [v2]

[Calvin Cheung]

On Fri, 29 Jan 2021 22:45:27 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   1. revert the changes in SharedStrings.java.
>>   2. replace most of the createArchive() calls with createArchiveAndCheck().
>>   3. factor out dumping a class list into the CDSTestUtils.dumpClassList() method.
>
> test/hotspot/jtreg/runtime/cds/appcds/StaticArchiveWithLambda.java line 54:
> 
>> 52:                        appClass);
>> 53:         CDSTestUtils.run(dumpOpts)
>> 54:                     .assertNormalExit();
> 
> I see several places with similar code. Maybe the above can be moved into a common method like
> 
> CDSTestUtils.dumpClassList(classlist, "-cp", appJar,  appClass);
> 
> `CDSTestUtils.dumpClassList` can internally call `assertNormaExit`, and return the `Result` so the test case can perform more tests if necessary.

Hi Ioi,

Thanks for your review!
I've incorporated all your comments in the 01 version of webrev.

thanks,
Calvin

-------------

PR: https://git.openjdk.java.net/jdk/pull/2297