RFR: 8262099: jcmd VM.metaspace should report unlimited size if MaxMetaspaceSize isn't specified [v2]

Yang Yi github.com+5010047+kelthuzadx at openjdk.java.net
Mon Feb 22 11:27:42 UTC 2021


On Mon, 22 Feb 2021 09:19:26 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Yang Yi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remain unchanged SAP copyright year, only update Oracle copyright year
>
> Change looks fine, thanks for fixing. Can you please add a comment like "see Metaspace::ergo_initialize()" ?
> 
> I think the only reason we align MaxMetaspaceSize down is to forestall any comparison overflows on metaspace expansion. But I am not sure this is even an issue. I would like a solution where we leave it at max_uint and check the comparisons for overflow instead. But this patch looks fine.
> 
> Make sure you run the associated JTreg test.
> 
> Cheers, Thomas

Hi Thomas, I've updated the patch according to your review comment. All related tests have passed. In addition, I added a new test case to ensure that it works well in the future. Also I have updated the SAP copyright year.(Please let me know if I misunderstand your meaning:-))

Thanks,
Yang Yi

-------------

PR: https://git.openjdk.java.net/jdk/pull/2671


More information about the hotspot-runtime-dev mailing list