RFR: 8262099: jcmd VM.metaspace should report unlimited size if MaxMetaspaceSize isn't specified [v3]

Yang Yi github.com+5010047+kelthuzadx at openjdk.java.net
Mon Feb 22 11:31:02 UTC 2021


> Hi,
> 
> Can I have a review of this minor fix about `jcmd VM.metaspace`?
> 
> When MaxMetaspaceSize is not specified, it would set to max_uintx, jcmd VM.metaspace reports metaspace summary information as follows:
> 
> $ ./jcmd <pid> VM.metaspace | grep MaxMetaspaceSize
> MaxMetaspaceSize: 17179869184.00 GB
> 
> Actually, this is a bug, the expected output should be:
> 
> MaxMetaspaceSize: unlimited
> 
> The root cause of the problem is that the MaxMetaspaceSize rounding performed during arguments parsing is inconsistent with the round checking in print_settings(metaspaceRerporter.cpp).

Yang Yi has updated the pull request incrementally with one additional commit since the last revision:

  add more testcase, and comment out change

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2671/files
  - new: https://git.openjdk.java.net/jdk/pull/2671/files/ca16d9cc..0be70d1d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2671&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2671&range=01-02

  Stats: 41 lines in 2 files changed: 24 ins; 1 del; 16 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2671.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2671/head:pull/2671

PR: https://git.openjdk.java.net/jdk/pull/2671


More information about the hotspot-runtime-dev mailing list