RFR: 8262424: Change multiple get_java_xxx() functions in thread.cpp into one function

[Coleen Phillimore]

On Fri, 26 Feb 2021 14:30:20 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this small fix to change the multiple get_java_xxx() functions in thread.cpp into a single function.
> 
> The fix was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.
> 
> Thanks, Harold

This looks good but I have two small suggested changes.

src/hotspot/share/runtime/thread.cpp line 903:

> 901: char java_runtime_version[128] = "";
> 902: char java_runtime_vendor_version[128] = "";
> 903: char java_runtime_vendor_vm_bug_url[128] = "";

Should these be static?

src/hotspot/share/runtime/thread.cpp line 907:

> 905: // Extract version and vendor specific information.
> 906: static const char* get_java_version_info(InstanceKlass* ik,
> 907:                                          Symbol* field_name,

Instead of Symbol* field name, can you pass const char * and use
TempNewSymbol field_name = StringTable::new_symbol(name);
and then these can be removed from vmSymbols.hpp also?

-------------

Changes requested by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2750