RFR: 8258896: Remove the JVM ForceFloatExceptions option [v2]

[Kim Barrett]

On Mon, 4 Jan 2021 20:59:16 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this change to replace the JVM ForceFloatExceptions flag with #ifdef (_DEBUG).  The change was tested with tiers 1 and 2 on Linux, Windows, and Mac OS, and tiers 3-5 on Windows x64.
>> 
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8258896: Remove the JVM ForceFloatExceptions option

Changes requested by kbarrett (Reviewer).

src/hotspot/os/windows/os_windows.cpp line 4186:

> 4184: 
> 4185:   // for debugging float code generation bugs
> 4186: #if defined(_DEBUG) && !defined(_WIN64)

Why `_DEBUG` rather than `ASSERT`?  This would be the only use of `_DEBUG` in all of HotSpot (other than the consistency checking between `PRODUCT`, `ASSERT`, and `_DEBUG` in debug.cpp).  It would also be only the 2nd use of `_DEBUG` in the entire jdk (the other being in the Windows version of libawt).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1932