RFR: 8234773: Fix ThreadsSMRSupport::_bootstrap_list [v2]

David Holmes dholmes at openjdk.java.net
Fri Jan 8 13:15:56 UTC 2021


On Tue, 5 Jan 2021 21:09:03 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make ThreadsList constructor explicit.
>
> Thumbs up.
> Like @dholmes-ora, I'm not familiar with this "explicit" stuff.

I'm now more familiar with the use of "explicit" so that part is fine too.

I'd prefer to use this syntax if it is applicable to this case:

ThreadsList ThreadsSMRSupport::_bootstrap_list(0);

as the `{ 0 }` syntax just looks weird to me as an implicit constructor invocation. Your call.

Thanks,
David

-------------

PR: https://git.openjdk.java.net/jdk/pull/1921


More information about the hotspot-runtime-dev mailing list