RFR: 8234773: Fix ThreadsSMRSupport::_bootstrap_list [v2]

[Kim Barrett]

> On Jan 8, 2021, at 8:15 AM, David Holmes <dholmes at openjdk.java.net> wrote:
> 
> On Tue, 5 Jan 2021 21:09:03 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
> 
>>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>>> 
>>>  Make ThreadsList constructor explicit.
>> 
>> Thumbs up.
>> Like @dholmes-ora, I'm not familiar with this "explicit" stuff.
> 
> I'm now more familiar with the use of "explicit" so that part is fine too.

Thanks.

> I'd prefer to use this syntax if it is applicable to this case:
> 
> ThreadsList ThreadsSMRSupport::_bootstrap_list(0);
> 
> as the `{ 0 }` syntax just looks weird to me as an implicit constructor invocation. Your call.

Uniform initialization is new to us, so will take some getting used to. But
there are some real advantages, some of which are mentioned in JDK-8252588,
along with cppreference.

I don't think we should go back and change existing usage, but I think the
benefits make it worth consistently preferring going forward. I'm starting
to train my fingers to use the new form, though Ioi seems to be doing much
better at that than I am.

> Thanks,
> David
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/1921