[jdk16] RFR: 8259275: JRuby crashes while resolving invokedynamic instruction [v2]

[Lois Foltan]

On Mon, 11 Jan 2021 18:51:21 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this proposed change which fixes 2 problems during CDS dump time:
>> 
>> - in `ClassListParser::resolve_indy()`, exception could be thrown from `bootstrap_specifier.resolve_bsm()` but was not handled;
>> - in `ConstantPool::remove_unshareable_info()`, tag was not setup correctly on error conditions.
>> 
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove commented code

src/hotspot/share/classfile/classListParser.cpp line 479:

> 477:     oop exception = THREAD->pending_exception();
> 478:     if (exception->is_a(SystemDictionary::Error_klass())) {
> 479:       CLEAR_PENDING_EXCEPTION;

Just for my clarification, why do you clear the pending exception in the case of Error_klass()?  Please consider adding a comment explaining this.

-------------

PR: https://git.openjdk.java.net/jdk16/pull/104