[jdk16] RFR: 8259275: JRuby crashes while resolving invokedynamic instruction [v2]

[Calvin Cheung]

On Mon, 11 Jan 2021 20:16:44 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove commented code
>
> src/hotspot/share/classfile/classListParser.cpp line 479:
> 
>> 477:     oop exception = THREAD->pending_exception();
>> 478:     if (exception->is_a(SystemDictionary::Error_klass())) {
>> 479:       CLEAR_PENDING_EXCEPTION;
> 
> Just for my clarification, why do you clear the pending exception in the case of Error_klass()?  Please consider adding a comment explaining this.

Hi Lois,

Thanks for your review. I've added some comment in `ClassListParser::resolve_indy` for the `Error_klass` case.

-------------

PR: https://git.openjdk.java.net/jdk16/pull/104