[jdk16] RFR: 8259275: JRuby crashes while resolving invokedynamic instruction [v2]

[David Holmes]

On Mon, 11 Jan 2021 21:52:24 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> src/hotspot/share/classfile/classListParser.cpp line 479:
>> 
>>> 477:     oop exception = THREAD->pending_exception();
>>> 478:     if (exception->is_a(SystemDictionary::Error_klass())) {
>>> 479:       CLEAR_PENDING_EXCEPTION;
>> 
>> Just for my clarification, why do you clear the pending exception in the case of Error_klass()?  Please consider adding a comment explaining this.
>
> Hi Lois,
> 
> Thanks for your review. I've added some comment in `ClassListParser::resolve_indy` for the `Error_klass` case.

I would have expected only LinkageErrors to be ignored as they are the only "expected" errors aren't they?

-------------

PR: https://git.openjdk.java.net/jdk16/pull/104