RFR: 8134540: Much nearly duplicated code for PerfMemory support

[David Holmes]

On Thu, 14 Jan 2021 07:58:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this change to merge the Unix-like PerfMemory_*.cpp source files into a single PerfMemory_posix.cpp source file.
>> 
>> The changes were tested on Mach5 tiers 1-5 on Linux, Windows, and Mac OS, and cross-builds were done for the S390, arm32, ppc, and x86 platforms.
>> 
>> Thanks, Harold
>
> Hi Harold,
> 
> I had an initial look. A few comments below.
> 
> The amount of Linux specific code is a bit concerning for a shared implementation.
> 
> Thanks,
> David

Hi Harold,

Sorry I forgot to say thanks for tackling this - deduplication is good! But maybe we can refactor the Linux specific bits more cleanly by pushing helper functions into the os namespace, just for Linux and then calling this via LINUX_ONLY.

Thanks,
David

-------------

PR: https://git.openjdk.java.net/jdk/pull/2037