RFR: 8260256: Leftover Thread uses after JDK-8223657

[Coleen Phillimore]

On Thu, 21 Jan 2021 19:00:16 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> JDK-8223657 cleaned up Thread arguments in SymbolTable, but there are some leftovers. Notably, SonarCloud reports that SymbolTableLookup::_thread is not initialized. I looked for `Thread` usages in `symbolTable.cpp`, and it seems only these two are missing. Maybe @coleenp can spot even more omissions somewhere.

Marked as reviewed by coleenp (Reviewer).

src/hotspot/share/classfile/symbolTable.cpp line 555:

> 553:   outputStream* _st;
> 554: public:
> 555:   DumpSymbol(outputStream* st) : _st(st) {}

I bet there used to be a ResourceMark rm(_thr); here once.
There's similar code in stringTable.cpp.  Doesn't seem beneficial to change it there.

src/hotspot/share/classfile/symbolTable.cpp line 351:

> 349: class SymbolTableLookup : StackObj {
> 350: private:
> 351:   Thread* _thread;

I thought I reviewed this already?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2188