RFR: 8259845: Move placeholder implementation details to cpp file and add logging [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Fri Jan 22 21:53:02 UTC 2021
On Fri, 22 Jan 2021 21:49:25 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Make 'log' inline.
>
> Marked as reviewed by iklam (Reviewer).
Thanks Ioi!
> src/hotspot/share/classfile/placeholders.cpp line 269:
>
>> 267:
>> 268: static void log(PlaceholderEntry* entry, const char* function, PlaceholderTable::classloadAction action) {
>> 269: if (log_is_enabled(Debug, class, load, placeholders)) {
>
> Maybe `log()` should be explicitly declared as an inline function, so that the `if (log_is_enabled(Debug, class, load, placeholders))` can be checked without making a function call?
OK.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2204
More information about the hotspot-runtime-dev
mailing list