RFR: 8259845: Move placeholder implementation details to cpp file and add logging [v2]

Lois Foltan lfoltan at openjdk.java.net
Fri Jan 22 22:16:47 UTC 2021


On Fri, 22 Jan 2021 21:53:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> See CR for details.
>> Tested with tier1-3 and manually by looking at the output.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make 'log' inline.

Looks good Coleen!
Lois

src/hotspot/share/classfile/placeholders.cpp line 260:

> 258: 
> 259: static const char* action_to_string(PlaceholderTable::classloadAction action) {
> 260:   switch (action) {

Method log is the only method that calls action_to_string.  Would you consider just adding the switch statement to the log method and doing away with action_to_string?  I'm fine either way just a preference comment.

-------------

Marked as reviewed by lfoltan (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2204


More information about the hotspot-runtime-dev mailing list