RFR: 8259845: Move placeholder implementation details to cpp file and add logging [v2]

[Coleen Phillimore]

On Fri, 22 Jan 2021 22:13:49 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make 'log' inline.
>
> Looks good Coleen!
> Lois

Thanks for the code review, Lois.

> src/hotspot/share/classfile/placeholders.cpp line 260:
> 
>> 258: 
>> 259: static const char* action_to_string(PlaceholderTable::classloadAction action) {
>> 260:   switch (action) {
> 
> Method log is the only method that calls action_to_string.  Would you consider just adding the switch statement to the log method and doing away with action_to_string?  I'm fine either way just a preference comment.

I had a look at importing the switch on action and it's neater the way I have it so I only have one print statement like:
    ls.print("%s %s ", function, action_to_string(action));

-------------

PR: https://git.openjdk.java.net/jdk/pull/2204