RFR: 8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS [v2]

Aleksey Shipilev shade at openjdk.java.net
Thu Jan 28 10:41:47 UTC 2021


On Thu, 28 Jan 2021 10:35:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/Metaspace/MaxMetaspaceSizeEnvVarTest.java line 36:
>> 
>>> 34:  * @library /test/lib
>>> 35:  * @run driver MaxMetaspaceSizeEnvVarTest
>>> 36:  */
>> 
>> I believe the conventional style is to do jtreg test definition the first thing, and then do imports.
>
> Thanks for the Review Aleksey - note I just updated the test with a missing test case.
> 
> I'm not aware of a specific convention here. :) I used the existing MaxMetaspaceSizeTest.java in the same directory as the template for this one. But I can change it if you insist.
> 
> Thanks,
> David

Please change if you are doing the test touchups anyway.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2275


More information about the hotspot-runtime-dev mailing list