RFR: 8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS [v2]

David Holmes dholmes at openjdk.java.net
Thu Jan 28 10:53:07 UTC 2021


On Thu, 28 Jan 2021 10:02:09 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Boost max from 1MB to 9MB as 1MB was too low for Aarch64 to startup
>
> test/hotspot/jtreg/runtime/Metaspace/MaxMetaspaceSizeEnvVarTest.java line 75:
> 
>> 73: 
>> 74:         int test = 1;
>> 75:         String msg = "Test " + test +": normal command-line flag";
> 
> I think you can dispense with `test` variable, and just print "Test: normal command-line flag", and later the name of env opts.

I find the numbering useful when scrolling through the jtr file.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2275


More information about the hotspot-runtime-dev mailing list