RFR: 8268014: Build failure on SUSE Linux Enterprise Server 11.4 (s390x) due to 'SYS_get_mempolicy' was not declared [v2]

[Jie Fu]

On Tue, 1 Jun 2021 11:22:15 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> > Hi, on newer s390x machines (SLES15.2) the value of SYS_get_mempolicy is 269 .
> > So a fix value per platform is not always correct.
> > However we have the define for SYS_get_mempolicy on this SLES15.2 machine.
> 
> Okay.
> Patch has been updated to check & try to use __NR_get_mempolicy first if SYS_get_mempolicy is not defined, which is suggested by @TheRealMDoerr in the JBS.
> Thanks.

Ah, using __NR_get_mempolicy is suggested by @MBaesken in the JBS.
Thanks @dholmes-ora for correcting me.

But I'm not sure if the following change is safe enough since libnuma source code also handles the case when __NR_get_mempolicy isn't defined [1] .


#if !defined(SYS_get_mempolicy) && defined(S390)
#define SYS_get_mempolicy __NR_get_mempolicy
#endif


I would suggest keeping the same logic for that case.
What do you think?
Thanks.

[1] https://github.com/numactl/numactl/blob/master/syscall.c#L29

-------------

PR: https://git.openjdk.java.net/jdk/pull/4277