RFR: 8267118: OutOfMemoryError cannot be caught as a Throwable [v3]
David Holmes
dholmes at openjdk.java.net
Tue Jun 1 21:47:28 UTC 2021
On Tue, 1 Jun 2021 20:14:24 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reworked the new logging to seperate Info and Debug levels to reduce verbosity, per
>> feedback from @coleenp @iklam
>
> src/hotspot/share/oops/method.cpp line 300:
>
>> 298: log_info(exceptions)("Found matching handler for exception of type \"%s\" in method \"%s\" at BCI: %d",
>> 299: ex_klass == NULL ? "NULL" : ex_klass->external_name(), mh()->name()->as_C_string(), handler_bci);
>> 300: }
>
> There's so much extra code added with this logging. It's hard to follow as it is. Could you just have the log_info level output in both this and the case above where you find the handler, here and above? debug level logging will include info level debugging.
The problem is that debug logging is step-by-step information, while the Info logging is a complete statement. So the Info message does not fit with the previous debug messages, hence the either-or approach.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4266
More information about the hotspot-runtime-dev
mailing list