RFR: 8267118: OutOfMemoryError cannot be caught as a Throwable [v3]

David Holmes dholmes at openjdk.java.net
Tue Jun 1 21:50:49 UTC 2021


On Tue, 1 Jun 2021 20:15:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reworked the new logging to seperate Info and Debug levels to reduce verbosity, per
>>   feedback from @coleenp @iklam
>
> src/hotspot/share/oops/method.cpp line 285:
> 
>> 283:         Klass* k = pool->klass_at(klass_index, THREAD);
>> 284:         if (HAS_PENDING_EXCEPTION) {
>> 285:         if (log_is_enabled(Debug, exceptions)) {
> 
> Technically, this would be interesting enough to be log_info level.

Perhaps, but again making it fit and provide sufficient contextual information is awkward and the throw is already captured at the Info level. So I would hope that if someone saw the unexpected throw logging they would use that as a cue to turn on debug logging to get more information.

Logging is really, really subjective - painfully so.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4266


More information about the hotspot-runtime-dev mailing list