RFR: JDK-8267138: Stray suffix when starting gtests via GTestWrapper.java
Thomas Stuefe
stuefe at openjdk.java.net
Thu Jun 10 10:00:27 UTC 2021
For JDK-8185734: "[Windows] Structured Exception Catcher missing around gtest execution", I specified that --gtest_catch_exceptions=0 should be specified to leave signal handling to the VM. This was needed to prevent the gtest runner from catching the stack-based SEH exceptions bubbling up from the tested VM, and leave them to our upstairs gtest runner wrapper to catch.
However, there is a typo:
--gtest_catch_exceptions=0test_result.xml
Unless I am mistaken, it did not seem to have impeded Windows gtests (in particular, the tests in runtime/test_safefetch.cpp). So I think this was a benign error.
-------------
Commit messages:
- remove typo
Changes: https://git.openjdk.java.net/jdk/pull/4025/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4025&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8267138
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/4025.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4025/head:pull/4025
PR: https://git.openjdk.java.net/jdk/pull/4025
More information about the hotspot-runtime-dev
mailing list