RFR: JDK-8267138: Stray suffix when starting gtests via GTestWrapper.java

Thomas Stuefe stuefe at openjdk.java.net
Fri Jun 25 16:18:03 UTC 2021


On Fri, 14 May 2021 06:18:04 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> For JDK-8185734: "[Windows] Structured Exception Catcher missing around gtest execution", I specified that `--gtest_catch_exceptions=0` should be specified when starting the gtestlauncher from within the gtest jtreg wrappers. The intent was to leave signal handling to the VM - needed is this for windows 32-bit where fault handling happens via stack-based SEH, and gtestrunner's own SEH handler would intercept exceptions bubbling up from faults in test coding. For more details, please see the description of JDK-8185734.
> 
> However turned out I added a typo. It did not prevent the option from working, but should be fixed nevertheless.
> 
> This is really really trivial. Thanks for reviewing.

Gentle ping. May I please have a review? This is really trivial. Thank you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4025


More information about the hotspot-runtime-dev mailing list