[jdk17] RFR: 8268522: InstanceKlass::can_be_verified_at_dumptime() returns opposite value [v2]

[David Holmes]

On Fri, 11 Jun 2021 18:13:20 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this small patch:
>> 
>> - correct the return value of `InstanceKlass::can_be_verified_at_dumptime()` to match the function's name;
>> - modify the call sites accordingly.
>> 
>> - [x] mach5 tiers 1,2,3
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change _is_shared_old_klass to _verified_at_dump_time

Hi Calvin,

The logic negation seems fine.

The change to shared_old_class also seems fine in general.

But there is one change that I'm querying as it seems a functional change.

Thanks,
David

src/hotspot/share/oops/klassVtable.cpp line 1098:

> 1096:      !MetaspaceShared::remapped_readwrite() &&
> 1097:      m->method_holder()->verified_at_dump_time() &&
> 1098:      klass->verified_at_dump_time()) {

This change seems to go beyond the simple logic negation. Why the change here?

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/31