[jdk17] RFR: 8268522: InstanceKlass::can_be_verified_at_dumptime() returns opposite value [v2]

[Calvin Cheung]

On Fri, 11 Jun 2021 22:03:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change _is_shared_old_klass to _verified_at_dump_time
>
> src/hotspot/share/oops/klassVtable.cpp line 1098:
> 
>> 1096:      !MetaspaceShared::remapped_readwrite() &&
>> 1097:      m->method_holder()->verified_at_dump_time() &&
>> 1098:      klass->verified_at_dump_time()) {
> 
> This change seems to go beyond the simple logic negation. Why the change here?

Hi David,

Thanks for your review!

The block of code you mentioned is being called during runtime. So it is more consistent to call `verified_at_dump_time()`.

Thanks,
Calvin

-------------

PR: https://git.openjdk.java.net/jdk17/pull/31