RFR: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *, wchar_t * *)"

David Holmes dholmes at openjdk.java.net
Thu Jun 17 05:58:26 UTC 2021


Please review this trivial fix to add a missing "static" to a function prototype. For some reason VS 16.9.3+ doesn't treat this as an error but earlier versions do (and gcc/g++ confirms).

Tested our CI builds remain okay with this change.

Thanks,
David

-------------

Commit messages:
 - 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"

Changes: https://git.openjdk.java.net/jdk/pull/4516/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4516&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8268927
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4516.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4516/head:pull/4516

PR: https://git.openjdk.java.net/jdk/pull/4516


More information about the hotspot-runtime-dev mailing list