RFR: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *, wchar_t * *)"

Thomas Stuefe stuefe at openjdk.java.net
Thu Jun 17 06:43:17 UTC 2021


On Thu, 17 Jun 2021 05:50:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review this trivial fix to add a missing "static" to a function prototype. For some reason VS 16.9.3+ doesn't treat this as an error but earlier versions do (and gcc/g++ confirms).
> 
> Tested our CI builds remain okay with this change.
> 
> Thanks,
> David

Looks good and trivial.

..Thomas

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4516


More information about the hotspot-runtime-dev mailing list