RFR: 8263640: hs_err improvement: handle class path longer than O_BUFLEN [v2]
Ioi Lam
iklam at openjdk.java.net
Mon Jun 28 22:58:05 UTC 2021
On Mon, 28 Jun 2021 22:39:32 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> src/hotspot/share/runtime/arguments.cpp line 1122:
>>
>>> 1120: }
>>> 1121: st->cr();
>>> 1122: }
>>
>> Maybe we can use `st->print_raw()` instead?
>
> Thanks for your review.
> I've changed it to st->print_raw_cr() so that st->cr() is not needed.
> I also removed the "@requires vm.cds" from the test since it is unrelated to cds.
How about doing this? This will make sure the print_raw_cr() path is tested (i.e., when generating hs_err files).
if (len == 0) {
st->print_raw_cr("<not set>");
} else {
st->print_raw_cr(path, len);
}
-------------
PR: https://git.openjdk.java.net/jdk/pull/4616
More information about the hotspot-runtime-dev
mailing list